esm: rewrite loader hooks test#46016
Merged
nodejs-github-bot merged 3 commits intonodejs:mainfrom Dec 31, 2022
Merged
Conversation
GeoffreyBooth
added
test
nodejs-github-bot
added
esm
Rewrite the test that validates that custom loader hooks are called from being a test that depends on internals to one that spawns a child process and checks its output to confirm expected behavior.
GeoffreyBooth
force-pushed
the
rewrite-loader-hooks-test
branch
from
64342b5 to
8c07ea8
Compare
aduh95
reviewed
Dec 30, 2022
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
aduh95
approved these changes
Dec 30, 2022
Collaborator
GeoffreyBooth
added
the
author ready
GeoffreyBooth
added
commit-queue-squash
nodejs-github-bot
removed
the
commit-queue
Collaborator
|
Landed in e2dd139 |
targos
pushed a commit
that referenced
this pull request
Jan 1, 2023
Rewrite the test that validates that custom loader hooks are called from being a test that depends on internals to one that spawns a child process and checks its output to confirm expected behavior. PR-URL: #46016 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Jacob Smith <jacob@frende.me>
Merged
RafaelGSS
pushed a commit
that referenced
this pull request
Jan 4, 2023
Rewrite the test that validates that custom loader hooks are called from being a test that depends on internals to one that spawns a child process and checks its output to confirm expected behavior. PR-URL: #46016 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Jacob Smith <jacob@frende.me>
RafaelGSS
pushed a commit
that referenced
this pull request
Jan 5, 2023
Rewrite the test that validates that custom loader hooks are called from being a test that depends on internals to one that spawns a child process and checks its output to confirm expected behavior. PR-URL: #46016 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Jacob Smith <jacob@frende.me>
juanarbol
pushed a commit
that referenced
this pull request
Jan 26, 2023
Rewrite the test that validates that custom loader hooks are called from being a test that depends on internals to one that spawns a child process and checks its output to confirm expected behavior. PR-URL: #46016 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Jacob Smith <jacob@frende.me>
Merged
juanarbol
pushed a commit
that referenced
this pull request
Jan 31, 2023
Rewrite the test that validates that custom loader hooks are called from being a test that depends on internals to one that spawns a child process and checks its output to confirm expected behavior. PR-URL: #46016 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Jacob Smith <jacob@frende.me>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a spinoff from #44710. As part of that work, I needed to rewrite this test to no longer depend on internals and invoke
ESMLoaderdirectly; instead it spawns anodechild process like most of the other loaders tests. The same result is confirmed, and this version of the test is less coupled to internal implementation details. I’m opening this as a standalone PR to confirm that this test passes for pre-refactor loaders code too, and to reduce the diff in the off-thread PR.@nodejs/loaders @nodejs/modules @nodejs/testing